fix(external_link): support 'external_link: true'

hexojs · Sep 24, 2019 · eb7b6ed · eb7b6ed
1 parent b2df82f
commit eb7b6ed
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/lib/plugins/filter/after_post_render/external_link.js b/lib/plugins/filter/after_post_render/external_link.js
@@ -25,7 +25,8 @@ const isExternal = (url, config) => {
 function externalLinkFilter(data) {
   const { config } = this;
 
-  if (typeof config.external_link === 'undefined' || typeof config.external_link === 'object') {
+  if (typeof config.external_link === 'undefined' || typeof config.external_link === 'object' ||
+    config.external_link === true) {
     config.external_link = Object.assign({
       enable: true,
       field: 'site',

diff --git a/lib/plugins/filter/after_render/external_link.js b/lib/plugins/filter/after_render/external_link.js
@@ -31,7 +31,8 @@ const isExternal = (url, config) => {
 function externalLinkFilter(data) {
   const { config } = this;
 
-  if (typeof config.external_link === 'undefined' || typeof config.external_link === 'object') {
+  if (typeof config.external_link === 'undefined' || typeof config.external_link === 'object' ||
+    config.external_link === true) {
     config.external_link = Object.assign({
       enable: true,
       field: 'site',

diff --git a/test/scripts/filters/external_link.js b/test/scripts/filters/external_link.js
@@ -90,7 +90,7 @@ describe('External link', () => {
     ].join('\n'));
   });
 
-  it('backward compatibility', () => {
+  it('old option - false', () => {
     const content = 'foo'
       + '<a href="https://hexo.io/">Hexo</a>'
       + 'bar';
@@ -107,6 +107,21 @@ describe('External link', () => {
     };
   });
 
+  it('old option - true', () => {
+    const content = '<a href="https://hexo.io/">Hexo</a>';
+
+    hexo.config.external_link = true;
+
+    const result = externalLink(content);
+    result.should.eql('<a href="https://hexo.io/" target="_blank" rel="noopener">Hexo</a>');
+
+    hexo.config.external_link = {
+      enable: true,
+      field: 'site',
+      exclude: ''
+    };
+  });
+
   it('exclude - string', () => {
     const content = [
       '<a href="https://foo.com/">Hexo</a>',