fix: external_link should use after_render

* also move meta_generator to after_render/ folder

lib/plugins/filter/after_post_render/index.js

@@ -3,6 +3,5 @@
 module.exports = ctx => {
   const { filter } = ctx.extend;
 
-  filter.register('after_post_render', require('./external_link'));
   filter.register('after_post_render', require('./excerpt'));
 };

lib/plugins/filter/after_post_render/external_link.js → lib/plugins/filter/after_render/external_link.js

@@ -8,13 +8,13 @@ function externalLinkFilter(data) {
 
   const siteHost = url.parse(config.url).hostname || config.url;
 
-  data.content = data.content.replace(/<a.*?(href=['"](.*?)['"]).*?>/gi, (str, hrefStr, href) => {
+  data = data.replace(/<a.*?(href=['"](.*?)['"]).*?>/gi, (str, hrefStr, href) => {
     if (/target=/gi.test(str)) return str;
 
-    const data = url.parse(href);
+    const parsedUrl = url.parse(href);
     // Exit if the link doesn't have protocol, which means it's a internal link
     // Exit if the url has same host with config.url
-    if (!data.protocol || data.hostname === siteHost) return str;
+    if (!parsedUrl.protocol || parsedUrl.hostname === siteHost) return str;
 
     if (/rel=/gi.test(str)) {
       str = str.replace(/rel="(.*?)"/gi, (relStr, rel) => {
@@ -27,6 +27,8 @@ function externalLinkFilter(data) {
     return str.replace(hrefStr, `${hrefStr} target="_blank" rel="noopener"`);
   });
 
+  return data;
+
 }
 
 module.exports = externalLinkFilter;

lib/plugins/filter/after_render/index.js

@@ -0,0 +1,8 @@
+'use strict';
+
+module.exports = ctx => {
+  const { filter } = ctx.extend;
+
+  filter.register('after_render:html', require('./external_link'));
+  filter.register('after_render:html', require('./meta_generator'));
+};

lib/plugins/filter/index.js

@@ -3,6 +3,7 @@
 module.exports = ctx => {
   const { filter } = ctx.extend;
 
+  require('./after_render')(ctx);
   require('./after_post_render')(ctx);
   require('./before_post_render')(ctx);
   require('./before_exit')(ctx);
@@ -11,5 +12,4 @@ module.exports = ctx => {
 
   filter.register('new_post_path', require('./new_post_path'));
   filter.register('post_permalink', require('./post_permalink'));
-  filter.register('after_render:html', require('./meta_generator'));
 };

test/scripts/filters/external_link.js

@@ -3,7 +3,8 @@
 describe('External link', () => {
   const Hexo = require('../../../lib/hexo');
   const hexo = new Hexo();
-  const externalLink = require('../../../lib/plugins/filter/after_post_render/external_link').bind(hexo);
+  const externalLink = require('../../../lib/plugins/filter/after_render/external_link').bind(hexo);
+  console.log(typeof externalLink);
 
   hexo.config.external_link = true;
   hexo.config.url = 'https://example.com';
@@ -46,11 +47,9 @@ describe('External link', () => {
       '<a href="https://example.com">Example Domain</a>'
     ].join('\n');
 
-    const data = {content};
-
-    externalLink(data);
+    const result = externalLink(content);
 
-    data.content.should.eql([
+    result.should.eql([
       '# External link test',
       '1. External link',
       '<a href="https://hexo.io/" target="_blank" rel="noopener">Hexo</a>',

test/scripts/filters/meta_generator.js

@@ -3,7 +3,7 @@
 describe('Meta Generator', () => {
   const Hexo = require('../../../lib/hexo');
   const hexo = new Hexo();
-  const metaGenerator = require('../../../lib/plugins/filter/meta_generator').bind(hexo);
+  const metaGenerator = require('../../../lib/plugins/filter/after_render/meta_generator').bind(hexo);
   const cheerio = require('cheerio');
 
   it('default', () => {