refactor(external_link): indexOf is faster than includes/test

hexojs · Nov 6, 2019 · 61dd31d · 61dd31d
1 parent 6d9ed7a
commit 61dd31d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/plugins/filter/after_post_render/external_link.js b/lib/plugins/filter/after_post_render/external_link.js
@@ -48,11 +48,11 @@ function externalLinkFilter(data) {
     : [config.external_link.exclude];
 
   data.content = data.content.replace(/<a.*?(href=['"](.*?)['"]).*?>/gi, (str, hrefStr, href) => {
-    if (/target=/gi.test(str) || !isExternal(href, config)) return str;
+    if (str.indexOf('target=') !== -1 || !isExternal(href, config)) return str;
 
-    if (/rel=/gi.test(str)) {
+    if (str.indexOf('rel=') !== -1) {
       str = str.replace(/rel="(.*?)"/gi, (relStr, rel) => {
-        if (!rel.includes('noopenner')) relStr = relStr.replace(rel, `${rel} noopener`);
+        if (rel.indexOf('noopenner') === -1) relStr = relStr.replace(rel, `${rel} noopener`);
         return relStr;
       });
       return str.replace(hrefStr, `${hrefStr} target="_blank"`);

diff --git a/lib/plugins/filter/after_render/external_link.js b/lib/plugins/filter/after_render/external_link.js
@@ -54,11 +54,11 @@ function externalLinkFilter(data) {
     : [config.external_link.exclude];
 
   data = data.replace(/<a.*?(href=['"](.*?)['"]).*?>/gi, (str, hrefStr, href) => {
-    if (/target=/gi.test(str) || !isExternal(href, config)) return str;
+    if (str.indexOf('target=') !== -1 || !isExternal(href, config)) return str;
 
-    if (/rel=/gi.test(str)) {
+    if (str.indexOf('rel=') !== -1) {
       str = str.replace(/rel="(.*?)"/gi, (relStr, rel) => {
-        if (!rel.includes('noopenner')) relStr = relStr.replace(rel, `${rel} noopener`);
+        if (rel.indexOf('noopenner') === -1) relStr = relStr.replace(rel, `${rel} noopener`);
         return relStr;
       });
       return str.replace(hrefStr, `${hrefStr} target="_blank"`);