Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(highlight): add an option to switch stripIndent #398

Merged
merged 4 commits into from Mar 31, 2024
Merged

feat(highlight): add an option to switch stripIndent #398

merged 4 commits into from Mar 31, 2024

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Feb 20, 2024

backwards compatibility

related hexojs/hexo#5422

@uiolee uiolee mentioned this pull request Feb 20, 2024
Merged
2 tasks
@coveralls
Copy link

coveralls commented Feb 20, 2024 •
edited

Coverage Status

coverage: 96.873% (+0.02%) from 96.856%
when pulling 85da560 on strip
into c061251 on master.

yoshinorin
yoshinorin reviewed Feb 23, 2024
View reviewed changes
lib/highlight.ts Outdated Show resolved Hide resolved
yoshinorin
yoshinorin reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And... would you please update the README?

https://github.com/hexojs/hexo-util/tree/0cbe3bb6c8bda06a64813630a0dedccdbfc2293e?tab=readme-ov-file#highlightstr-options

https://github.com/hexojs/hexo-util?tab=readme-ov-file#prismhighlightstr-options

@uiolee uiolee marked this pull request as draft March 3, 2024 08:05
@TripleCamera
Copy link

Hi. How is everything going? It's the end of March already. 👀

@uiolee uiolee changed the title feat(highlight): provide an option to disable stripIndent feat(highlight): add an option to switch stripIndent Mar 30, 2024
@uiolee uiolee marked this pull request as ready for review March 30, 2024 12:19
@uiolee
Copy link
Member Author

uiolee commented Mar 30, 2024

review pls

yoshinorin
yoshinorin approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yoshinorin yoshinorin merged commit 4e62f87 into master Mar 31, 2024
24 checks passed
@yoshinorin yoshinorin deleted the strip branch March 31, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uiolee @coveralls @TripleCamera @yoshinorin