Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace nyc with c8 #356

Merged
merged 2 commits into from
Aug 31, 2023
Merged

test: replace nyc with c8 #356

merged 2 commits into from
Aug 31, 2023

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Aug 28, 2023

@coveralls
Copy link

coveralls commented Aug 28, 2023 •
edited

Coverage Status

coverage: 95.249% (-0.2%) from 95.422% when pulling 8ffbbba on uiolee:c8 into 7dda4e5 on hexojs:master.

@uiolee
Copy link
Member Author

uiolee commented Aug 28, 2023

coverage in ci is lower than that in my pc

yoshinorin
yoshinorin reviewed Aug 31, 2023
View reviewed changes
.nycrc.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO:

We should change the filename from .nycrc.json to .c8rc.json.

refs: https://github.com/bcoe/c8/tree/a13584d5be5259ebb6a00455d352c3e8b16006de#cli-options--configuration

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think so

@uiolee uiolee merged commit d090bd2 into hexojs:master Aug 31, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin left review comments

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uiolee @coveralls @yoshinorin @stevenjoezhang