Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump highlight.js from 9.18.1 to 10.0.0 #192

Merged
merged 2 commits into from Apr 25, 2020
Merged

chore(deps): bump highlight.js from 9.18.1 to 10.0.0 #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e27895d
chore(deps): bump highlight.js from 9.18.1 to 10.0.0
dependabot-preview[bot] Apr 22, 2020
84538d6
test(highlight): sublanguage only works with 'autoDetect'
curbengh Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -47,7 +47,7 @@
"camel-case": "^4.0.0",
"cross-spawn": "^7.0.0",
"deepmerge": "^4.2.2",
"highlight.js": "^9.13.1",
"highlight.js": "^10.0.0",
"htmlparser2": "^4.0.0",
"prismjs": "^1.17.1",
"punycode.js": "^2.1.0",
Expand Down
6 changes: 3 additions & 3 deletions test/highlight.spec.js
View file
Open in desktop
Expand Up @@ -220,11 +220,11 @@ describe('highlight', () => {

it('highlight sublanguages', done => {
const str = '<node><?php echo "foo"; ?></node>';
const result = highlight(str, {lang: 'xml'});
const result = highlight(str, { autoDetect: true });
result.should.eql([
'<figure class="highlight xml"><table><tr>',
'<figure class="highlight php-template"><table><tr>',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xml may be detected as php-template, see upstream changelog.

gutter(1, 1),
code('<span class="tag">&lt;<span class="name">node</span>&gt;</span><span class="php"><span class="meta">&lt;?php</span> <span class="keyword">echo</span> <span class="string">"foo"</span>; <span class="meta">?&gt;</span></span><span class="tag">&lt;/<span class="name">node</span>&gt;</span>', null),
code('<span class="xml"><span class="tag">&lt;<span class="name">node</span>&gt;</span></span><span class="php"><span class="meta">&lt;?php</span> <span class="keyword">echo</span> <span class="string">"foo"</span>; <span class="meta">?&gt;</span></span><span class="xml"><span class="tag">&lt;/<span class="name">node</span>&gt;</span></span>', null),
end
].join(''));
validateHtmlAsync(result, done);
Expand Down