perf(encode/decodeURL): use legacy url.parse() to avoid try...catch() #128

curbengh · 2019-11-10T06:16:31Z

TL;DR

  try {
    return new URL(str);
  } catch (err) {
    return str;
  }

is expensive.

coveralls · 2019-11-10T06:17:50Z

Coverage decreased (-0.06%) to 95.395% when pulling edb74ff on curbengh:parse-encode-url into 71bbcc4 on hexojs:master.

curbengh added 3 commits November 10, 2019 06:05

perf(encodeURL): use legacy url.parse() to avoid try...catch()

1834e89

perf(decodeURL): use legacy url.parse() to avoid try...catch()

0fab976

docs: explain purpose of checking URL.origin

edb74ff

curbengh requested a review from a team November 10, 2019 06:16

curbengh added this to In progress in Drop legacy URL API via automation Nov 10, 2019

curbengh moved this from In progress to To do in Drop legacy URL API Nov 10, 2019

SukkaW approved these changes Nov 10, 2019

View reviewed changes

curbengh merged commit fbdf4e0 into hexojs:master Nov 17, 2019

Drop legacy URL API automation moved this from To do to Done Nov 17, 2019

curbengh deleted the parse-encode-url branch November 17, 2019 03:21

Provide feedback