Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hash): drop HashStream() #198

Merged
merged 1 commit into from Apr 27, 2020
Merged

feat(hash): drop HashStream() #198

merged 1 commit into from Apr 27, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Apr 27, 2020 •
edited

this finally drops HashStream() which has been long deprecated since #45.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 96.955% when pulling 3921c74 on curbengh:deprecate-hashstream into f90fd44 on hexojs:master.

@SukkaW
Copy link
Member

SukkaW commented Apr 27, 2020 •
edited

FYI, hexo is still relying on HashStream, which means those code should be refactored after hexo-util releasing a new version.

https://github.com/search?q=org%3Ahexojs+HashStream&type=Code

@SukkaW SukkaW merged commit 20ab0be into hexojs:master Apr 27, 2020
@SukkaW SukkaW mentioned this pull request Apr 27, 2020
Merged
2 tasks
@curbengh curbengh deleted the deprecate-hashstream branch April 28, 2020 01:11
@curbengh curbengh mentioned this pull request Apr 30, 2020
Merged
@liby liby mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@curbengh @coveralls @SukkaW @stevenjoezhang