Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop Node.js 10 #59

Merged
merged 6 commits into from Mar 31, 2021
Merged

chore: drop Node.js 10 #59

merged 6 commits into from Mar 31, 2021

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Feb 8, 2021 •
edited

See also #51

@stevenjoezhang stevenjoezhang mentioned this pull request Mar 25, 2021
Closed
@stevenjoezhang stevenjoezhang marked this pull request as ready for review March 29, 2021 05:21
@stevenjoezhang stevenjoezhang requested a review from a team March 29, 2021 05:22
@tomap
Copy link
Contributor

tomap commented Mar 29, 2021

According to https://node.green/ there are new feature une node 12.9 Shouldn't we use this version?

@tomap
Copy link
Contributor

tomap commented Mar 29, 2021

Also, the ci is still run by travis AND is testing against node 10. Shouldn't we switch to github actions?

@coveralls
Copy link

coveralls commented Mar 29, 2021 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 98436a8 on node12 into b70a66a on master.

@stevenjoezhang stevenjoezhang merged commit 1a637a0 into master Mar 31, 2021
@stevenjoezhang stevenjoezhang deleted the node12 branch March 31, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenjoezhang @tomap @coveralls