Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only shorten feeds at occurrences of delimiters #52

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

wiwie
Copy link
Contributor

@wiwie wiwie commented Feb 12, 2017

With the content limit (default: 140) it can happen, that words are cut in the middle. This option allows to specify a list of delimiters which are used when shortening post contents:

  • We only cut at occurrences of the specified delimiters;
  • We probe the delimiters in order, and use the first one for shortening that occurs in the post content;
  • If none of them occurs, we cut at content_limit (e.g. 140);

@coveralls
Copy link

coveralls commented Feb 12, 2017

Coverage Status

Coverage decreased (-21.9%) to 78.125% when pulling b973425 on wiwie:post-content-delimiter into 19ab397 on hexojs:master.

@coveralls
Copy link

coveralls commented Feb 12, 2017

Coverage Status

Coverage decreased (-33.3%) to 66.667% when pulling 57c2dd0 on wiwie:post-content-delimiter into 19ab397 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-33.3%) to 66.667% when pulling 57c2dd0 on wiwie:post-content-delimiter into 19ab397 on hexojs:master.

@coveralls
Copy link

coveralls commented Feb 17, 2017

Coverage Status

Coverage decreased (-33.3%) to 66.667% when pulling bb06418 on wiwie:post-content-delimiter into 19ab397 on hexojs:master.

@tomap
Copy link
Contributor

tomap commented Nov 16, 2019

Your PR looks interesting but contains too many changes to be merged. could you redo your PR with a single change at the time?

@tomap
Copy link
Contributor

tomap commented Nov 16, 2019

I believe most of this PR is already in master. Maybe not the thumbnail part? would you be willing to make a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants