fix: compatible with Node.js 14 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
requested review from
segayuu,
yoshinorin,
jiangtj,
stevenjoezhang and
curbengh
SukkaW
commented
Apr 24, 2020
| @@ -190,7 +193,7 @@ async function _copyDir(src, dest, options, parent) { | |||
| return _copyDir(childSrc, childDest, options, currentPath); | |||
| } | |||
|
|
|||
| return copyFile(childSrc, childDest, options).thenReturn(currentPath); | |||
| return copyFile(childSrc, childDest).thenReturn(currentPath); | |||
There was a problem hiding this comment.
The options here is for copyDir ({ ignoreHidden, ignorePattern }) which is not related with copyFile, so I just simply remove it.
SukkaW
commented
Apr 24, 2020
| @@ -127,6 +129,7 @@ function copyFile(src, dest, flags, callback) { | |||
| if (!dest) throw new TypeError('dest is required!'); | |||
| if (typeof flags === 'function') { | |||
| callback = flags; | |||
| flags = undefined; | |||
There was a problem hiding this comment.
Node.js 14 implemented a type check (nodejs/node@a13500f) so flags won't accept function any more.
SukkaW
commented
Apr 24, 2020
| @@ -89,6 +89,8 @@ function checkParentSync(path) { | |||
| function writeFile(path, data, options, callback) { | |||
| if (!path) throw new TypeError('path is required!'); | |||
|
|
|||
| if (!data) data = ''; | |||
There was a problem hiding this comment.
In the test cases we use writeFile(path) to create an empty file (leave data as an undefined value) will no longer be accepted by Node.js 14.
This was referenced Apr 24, 2020
Closed
stevenjoezhang
approved these changes
Apr 24, 2020
|
@curbengh Done. |
stevenjoezhang
approved these changes
Apr 25, 2020
Closed
curbengh
approved these changes
Apr 25, 2020
This was referenced May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some fixes to make
hexo-fscompatible with Node.js 14.Related issue: hexojs/hexo#4260 hexojs/hexo#4263