refactor/perf: regexp & split shorthand #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
commented
Jul 24, 2020
Comment on lines
+11
to
+23
| const matchOld = str.match(rFrontMatter); | ||
| if (matchOld) { | ||
| return { | ||
| data: matchOld[2], | ||
| content: matchOld[3] || '', | ||
| separator: matchOld[1], | ||
| prefixSeparator: true | ||
| }; | ||
| } | ||
|
|
||
| function splitOld(str) { | ||
| const match = str.match(rFrontMatter); | ||
| if (rPrefixSep.test(str)) return { content: str }; | ||
|
|
||
| return { | ||
| data: match[2], | ||
| content: match[3] || '', | ||
| separator: match[1], | ||
| prefixSeparator: true | ||
| }; | ||
| } | ||
| const matchNew = str.match(rFrontMatterNew); |
There was a problem hiding this comment.
Before
- old: test old pattern -> match old pattern
- new: test old pattern -> test new pattern -> match new pattern
After:
- old: match old pattern
- new: match old pattern -> match new pattern
As I find out in hexojs/hexo#4436, there is no significant performance difference between String#match & RegExp#test.
|
Test result & benchmark can be see here: https://github.com/SukkaW/hexo/tree/test-new-yfm-perf |
SukkaW
force-pushed
the
refactor-regexp
branch
2 times, most recently
from
5946521
to
ca0700f
Compare
SukkaW
commented
Jul 24, 2020
| @@ -172,7 +166,7 @@ function stringifyJSON(obj) { | |||
| } | |||
|
|
|||
| function doubleDigit(num) { | |||
| return num < 10 ? `0${num}` : num; | |||
| return num.toString().padStart(2, '0'); | |||
There was a problem hiding this comment.
It is from Node.js's util.
Merged
curbengh
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.