Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: always update user's name & email #353

Merged
merged 2 commits into from Apr 14, 2024
Merged

feat: always update user's name & email #353

merged 2 commits into from Apr 14, 2024

Conversation

stevenjoezhang
Copy link
Member

check list

  • Add test cases for the changes.
  • Passed the CI test.

Description

Issue resolved: #112

Additionally, I have rewritten some code using async/await, which makes it look cleaner.

Additional information

@coveralls
Copy link

coveralls commented Apr 10, 2024 •
edited

Coverage Status

coverage: 100.0%. remained the same
when pulling d8a79b5 on deployer
into 3eccb67 on master.

uiolee
uiolee approved these changes Apr 14, 2024
View reviewed changes
lib/deployer.js Outdated Show resolved Hide resolved
@stevenjoezhang
Update deployer.js
d8a79b5 
Signed-off-by: Mimi <1119186082@qq.com>
@stevenjoezhang stevenjoezhang merged commit 880a3c3 into master Apr 14, 2024
12 checks passed
@stevenjoezhang stevenjoezhang deleted the deployer branch April 14, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiolee uiolee uiolee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deployer ignores user's name & email specified in _config.yml deploy/name and deploy/email
3 participants
@stevenjoezhang @coveralls @uiolee