Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: answer frequently asked questions #351

Merged
merged 5 commits into from Apr 10, 2024
Merged

docs: answer frequently asked questions #351

merged 5 commits into from Apr 10, 2024

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Mar 30, 2024

Issue resolved: #71
Issue resolved: #87
Issue resolved: #175
Issue resolved: hexojs/hexo#3513

@coveralls
Copy link

coveralls commented Mar 30, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 56a141c on docs-cname
into 9cd7e94 on master.

Copy link
Member

@uiolee uiolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions are for reference only.

BTW, I think we had better announce to users that if they use hexo-deployer-git, then they should no longer make manual commits to the target repository other than using hexo-deployer-git. Because the changes they make will always be overwritten by hexo-deployer-git

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -113,6 +113,22 @@ Additional guides:
- Create a GitHub Personal Access Token. [[Link]](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line)
- Add authentication token to Travis CI. [[Link]](https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings)

## Custom Domain Issue with CNAME File

If you are using a custom domain with GitHub Pages, you might have encountered an issue where your custom domain configuration gets lost after deploying updates to your site. This problem occurs due to the deletion of the `CNAME` file in the root of the deployed directory during the git commit and push process performed by the `hexo-deployer-git` plugin.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CNAME file was overwritten rather than deleted

stevenjoezhang and others added 3 commits March 31, 2024 13:53
Co-authored-by: Uiolee <22849383+uiolee@users.noreply.github.com>
Co-authored-by: Uiolee <22849383+uiolee@users.noreply.github.com>
@stevenjoezhang
Copy link
Member Author

Thank you for your suggestion. I have added a section in the README explaining the force push behavior of this plugin.

@stevenjoezhang stevenjoezhang changed the title docs: Custom Domain Issue with CNAME File docs: answer frequently asked questions Mar 31, 2024
@stevenjoezhang stevenjoezhang merged commit 3eccb67 into master Apr 10, 2024
10 of 12 checks passed
@stevenjoezhang stevenjoezhang deleted the docs-cname branch April 10, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants