Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error code should be accessed from error object directly #190

Merged
merged 1 commit into from Apr 27, 2020
Merged

fix: error code should be accessed from error object directly #190

merged 1 commit into from Apr 27, 2020

Conversation

curbengh
Copy link
Contributor

continuation of #185

@curbengh
Copy link
Contributor Author

It might be due to hexojs/hexo-fs#53. I guess Bluebird emits error.cause.code while native promise emits error.code.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 84.677% when pulling bde2137 on curbengh:err-code into 37f654a on hexojs:master.

@SukkaW SukkaW merged commit 960c52a into hexojs:master Apr 27, 2020
@SukkaW SukkaW mentioned this pull request Apr 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curbengh @coveralls @SukkaW