Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking Change] Upgrade eslint-plugin-node #9

Merged
merged 2 commits into from
Jul 20, 2018
Merged

[Breaking Change] Upgrade eslint-plugin-node #9

merged 2 commits into from
Jul 20, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Jul 18, 2018

This PR is partially applying #8 .

@segayuu segayuu requested a review from a team July 18, 2018 01:22
@segayuu segayuu changed the title Upgrade eslint plugin node Upgrade eslint-plugin-node Jul 18, 2018
@JLHwung
Copy link
Contributor

JLHwung commented Jul 18, 2018

This PR should be a breaking change. I suggest do a major release on this revision.

@segayuu segayuu changed the title Upgrade eslint-plugin-node [Breaking Change] Upgrade eslint-plugin-node Jul 18, 2018
@segayuu
Copy link
Contributor Author

segayuu commented Jul 19, 2018

If I do major update I would like to reflect #7 at the same time.
Should not we create a future, not a master branch, and merge it there?

@segayuu segayuu changed the base branch from master to future July 20, 2018 00:25
@segayuu segayuu merged commit 27506a2 into hexojs:future Jul 20, 2018
@segayuu segayuu deleted the upgrade-eslint-plugin-node branch July 20, 2018 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demurgos demurgos demurgos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@segayuu @JLHwung @demurgos