Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HCP packer support #122

Merged
merged 5 commits into from
Jun 4, 2024
Merged

feat: add HCP packer support #122

merged 5 commits into from
Jun 4, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Nov 27, 2023

This pull request adds support for the HCP Packer registry by including the necessary metadata in the image state.

For more details, see: https://developer.hashicorp.com/packer/docs/plugins/creation/hcp-support

Continuation of #91 after accidentally closing the PR.

@jooola jooola force-pushed the ajax-ryzhyi-r/main branch 2 times, most recently from 6abb7c5 to 242ce34 Compare December 13, 2023 11:19
@jooola jooola marked this pull request as ready for review January 2, 2024 12:03
@jooola jooola requested a review from a team as a code owner January 2, 2024 12:03
@jooola jooola force-pushed the ajax-ryzhyi-r/main branch 3 times, most recently from 0a39933 to e563c5a Compare May 29, 2024 15:44
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 32.49%. Comparing base (1c4db33) to head (472d983).

Files Patch % Lines
builder/hcloud/builder.go 0.00% 6 Missing ⚠️
builder/hcloud/step_create_server.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   29.48%   32.49%   +3.01%     
==========================================
  Files          11       11              
  Lines         641      677      +36     
==========================================
+ Hits          189      220      +31     
- Misses        428      433       +5     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola requested a review from apricote May 31, 2024 10:10
ajax-ryzhyi-r and others added 5 commits June 3, 2024 10:17
Co-authored-by: Jonas Lammler <jonas.lammler@hetzner-cloud.de>
Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
@jooola jooola merged commit 85435ef into main Jun 4, 2024
10 checks passed
@jooola jooola deleted the ajax-ryzhyi-r/main branch June 4, 2024 14:22
jooola pushed a commit that referenced this pull request Jun 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](v1.4.0...v1.5.0)
(2024-06-05)


### Features

* add HCP packer support
([#122](#122))
([85435ef](85435ef))
* allow disabling the server public ips
([#190](#190))
([82e6cdb](82e6cdb)),
closes
[#188](#188)


### Bug Fixes

* ensure the upgrade server type is not nil
([#182](#182))
([d297dcb](d297dcb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants