fix: improve error message format with correlation id #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
lowercase-correlation-id
branch
from
fe49268
to
2893806
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 80.72% 80.69% -0.04%
==========================================
Files 34 34
Lines 5770 5770
==========================================
- Hits 4658 4656 -2
- Misses 707 708 +1
- Partials 405 406 +1 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
May 6, 2024
jooola
added
the
backport release-1.x
github-actions bot
pushed a commit
that referenced
this pull request
May 6, 2024
This improves the format of our error message, as they might be printed to the users. Before: ``` hcloud: server name is already used (uniqueness_error) (Correlation ID: d5064a1f0bb9de4b) ``` After: ``` hcloud: server name is already used (uniqueness_error, d5064a1f0bb9de4b) ``` (cherry picked from commit 013477f)
jooola
added a commit
that referenced
this pull request
May 6, 2024
…se-1.x] (#431) This improves the format of our error message, as they might be printed to the users. Before: ``` hcloud: server name is already used (uniqueness_error) (Correlation ID: d5064a1f0bb9de4b) ``` After: ``` hcloud: server name is already used (uniqueness_error, d5064a1f0bb9de4b) ``` --- Backport 013477f from #430. BEGIN_COMMIT_OVERRIDE fix: improve error message format with correlation id END_COMMIT_OVERRIDE Co-authored-by: Jonas L <jooola@users.noreply.github.com>
jooola
pushed a commit
that referenced
this pull request
May 6, 2024
🤖 I have created a release *beep* *boop* --- ## [2.8.0](v2.7.2...v2.8.0) (2024-05-06) ### Features * **error:** show internal correlation id in error messages ([#411](#411)) ([6c96d19](6c96d19)) * implement actions waiter ([#407](#407)) ([1e3fa70](1e3fa70)) * require Go >= 1.21 ([#424](#424)) ([d4f4000](d4f4000)) ### Bug Fixes * improve error message format with correlation id ([#430](#430)) ([013477f](013477f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the format of our error message, as they might be printed to the users.
Before:
After: