Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(action): fix link to WaitForFunc #429

Merged
merged 2 commits into from
May 6, 2024
Merged

docs(action): fix link to WaitForFunc #429

merged 2 commits into from
May 6, 2024

Conversation

apricote
Copy link
Member

@apricote apricote commented May 4, 2024

@apricote apricote self-assigned this May 4, 2024
@apricote apricote requested a review from a team as a code owner May 4, 2024 19:12
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (1e3fa70) to head (1f59164).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   80.69%   80.72%   +0.03%     
==========================================
  Files          34       34              
  Lines        5770     5770              
==========================================
+ Hits         4656     4658       +2     
+ Misses        708      707       -1     
+ Partials      406      405       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote apricote merged commit 94229eb into main May 6, 2024
4 checks passed
@apricote apricote deleted the docs-action-waitfor branch May 6, 2024 08:40
@jooola jooola added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

The backport to release-1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-429-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 94229eba296bbb03727eec7a028276a14db33431
# Push it to GitHub
git push --set-upstream origin backport-429-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.x

Then, create a pull request where the base branch is release-1.x and the compare/head branch is backport-429-to-release-1.x.

jooola pushed a commit that referenced this pull request May 6, 2024
jooola added a commit that referenced this pull request May 6, 2024
…434)

Link was not working properly in current `main`:

https://pkg.go.dev/github.com/hetznercloud/hcloud-go/v2/hcloud@v2.7.3-0.20240503164107-1e3fa7033d8a#ActionClient.WaitFor

(cherry picked from commit 94229eb)

BEGIN_COMMIT_OVERRIDE
docs(action): fix link to WaitForFunc
END_COMMIT_OVERRIDE

Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants