Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require Go >= 1.21 #424

Merged
merged 1 commit into from
Apr 30, 2024
Merged

feat: require Go >= 1.21 #424

merged 1 commit into from
Apr 30, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Apr 30, 2024

This is required for us to use the maps stdlib.

@jooola jooola requested a review from a team as a code owner April 30, 2024 08:19
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (575c24c) to head (8f52466).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files          33       33           
  Lines        5756     5756           
=======================================
  Hits         4630     4630           
  Misses        718      718           
  Partials      408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit d4f4000 into main Apr 30, 2024
4 checks passed
@jooola jooola deleted the require-go-1.21 branch April 30, 2024 08:24
@jooola jooola added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label Apr 30, 2024
Copy link
Contributor

The backport to release-1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-424-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4f40009016c3ed5bb14ef9ae16bcf6aefa90fee
# Push it to GitHub
git push --set-upstream origin backport-424-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.x

Then, create a pull request where the base branch is release-1.x and the compare/head branch is backport-424-to-release-1.x.

jooola added a commit that referenced this pull request Apr 30, 2024
This is required for us to use the `maps` stdlib.

(cherry picked from commit d4f4000)
jooola added a commit that referenced this pull request Apr 30, 2024
This is required for us to use the `maps` stdlib.

(cherry picked from commit d4f4000)
jooola added a commit that referenced this pull request Apr 30, 2024
This is required for us to use the `maps` stdlib.

(cherry picked from commit d4f4000)
jooola added a commit that referenced this pull request Apr 30, 2024
This is required for us to use the `maps` stdlib.

(cherry picked from commit d4f4000)

BEGIN_COMMIT_OVERRIDE
feat: require Go >= 1.21
END_COMMIT_OVERRIDE
jooola pushed a commit that referenced this pull request May 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.8.0](v2.7.2...v2.8.0)
(2024-05-06)


### Features

* **error:** show internal correlation id in error messages
([#411](#411))
([6c96d19](6c96d19))
* implement actions waiter
([#407](#407))
([1e3fa70](1e3fa70))
* require Go >= 1.21
([#424](#424))
([d4f4000](d4f4000))


### Bug Fixes

* improve error message format with correlation id
([#430](#430))
([013477f](013477f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants