Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move watch functions to dedicated file #423

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Apr 29, 2024

This adds a clear separation between the actions API client and the actions watch functions.

@jooola jooola requested a review from a team as a code owner April 29, 2024 18:54
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 84.88372% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 80.43%. Comparing base (87149f3) to head (2304143).

Files Patch % Lines
hcloud/action_watch.go 84.88% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   80.43%   80.43%           
=======================================
  Files          32       33    +1     
  Lines        5756     5756           
=======================================
  Hits         4630     4630           
  Misses        718      718           
  Partials      408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola changed the title refactor: move watch function to dedicated file refactor: move watch functions to dedicated file Apr 29, 2024
@jooola jooola self-assigned this Apr 29, 2024
@jooola jooola merged commit 575c24c into main Apr 30, 2024
5 checks passed
@jooola jooola deleted the refactor-actions-watch branch April 30, 2024 06:48
@jooola jooola added the backport release-1.x Open PR against release-1.x with these changes after the PR is merged. label Apr 30, 2024
Copy link
Contributor

The backport to release-1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-423-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 575c24c57e5a38c48ca747864753b43cd7a8261b
# Push it to GitHub
git push --set-upstream origin backport-423-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.x

Then, create a pull request where the base branch is release-1.x and the compare/head branch is backport-423-to-release-1.x.

jooola added a commit that referenced this pull request May 6, 2024
This adds a clear separation between the actions API client and the
actions watch functions.

(cherry picked from commit 575c24c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.x Open PR against release-1.x with these changes after the PR is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants