feat: implement actions waiter #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 80.43% 80.69% +0.25%
==========================================
Files 33 34 +1
Lines 5756 5770 +14
==========================================
+ Hits 4630 4656 +26
+ Misses 718 708 -10
+ Partials 408 406 -2 ☔ View full report in Codecov by Sentry. |
jooola
commented
Apr 18, 2024
jooola
force-pushed
the
new-action-waiter
branch
4 times, most recently
from
704af1e
to
1c3c707
Compare
apricote
requested changes
Apr 30, 2024
jooola
force-pushed
the
new-action-waiter
branch
from
1c3c707
to
c39b609
Compare
jooola
force-pushed
the
new-action-waiter
branch
from
c39b609
to
7bb1a7b
Compare
|
I fixed the few comments. I didn't use this branch in another project, I'll try it out. |
jooola
added
the
backport release-1.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-407-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e3fa7033d8a1cea1c0a9007a6255798979f0771
# Push it to GitHub
git push --set-upstream origin backport-407-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.xThen, create a pull request where the |
jooola
added a commit
that referenced
this pull request
May 6, 2024
Implement a simpler and more versatile waiting functions for actions. Most use cases when waiting for actions is to return early if an action fails. If all actions must be waited until completion, the users should use the `WaitForFunc` function. If the final actions objects are needed, the users should use the `WaitForFunc` function to store the final actions using the `handleUpdate` callback. This deprecates the `ActionClient.WatchOverallProgress` and `ActionClient.WatchProgress` methods. (cherry picked from commit 1e3fa70)
jooola
added a commit
that referenced
this pull request
May 6, 2024
Implement a simpler and more versatile waiting functions for actions. Most use cases when waiting for actions is to return early if an action fails. If all actions must be waited until completion, the users should use the `WaitForFunc` function. If the final actions objects are needed, the users should use the `WaitForFunc` function to store the final actions using the `handleUpdate` callback. This deprecates the `ActionClient.WatchOverallProgress` and `ActionClient.WatchProgress` methods. (cherry picked from commit 1e3fa70) BEGIN_COMMIT_OVERRIDE feat: implement actions waiter END_COMMIT_OVERRIDE
jooola
pushed a commit
that referenced
this pull request
May 6, 2024
🤖 I have created a release *beep* *boop* --- ## [2.8.0](v2.7.2...v2.8.0) (2024-05-06) ### Features * **error:** show internal correlation id in error messages ([#411](#411)) ([6c96d19](6c96d19)) * implement actions waiter ([#407](#407)) ([1e3fa70](1e3fa70)) * require Go >= 1.21 ([#424](#424)) ([d4f4000](d4f4000)) ### Bug Fixes * improve error message format with correlation id ([#430](#430)) ([013477f](013477f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a simpler and more versatile waiting functions for actions.
Most use cases when waiting for actions is to return early if an action fails. If all actions must be waited until completion, the users should use the
WaitForFuncfunction.If the final actions objects are needed, the users should use the
WaitForFuncfunction to store the final actions using thehandleUpdatecallback.This deprecates the
ActionClient.WatchOverallProgressandActionClient.WatchProgressmethods.