Allow empty labels (#207)

Co-authored-by: Lars Pickelin <lars.pickelin@hetzner-cloud.de>
hetznercloud · Jul 29, 2022 · 390daad · 390daad
1 parent d39392d
commit 390daad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/hcloud/labels.go b/hcloud/labels.go
@@ -7,7 +7,7 @@ import (
 
 var keyRegexp = regexp.MustCompile(
 	`^([a-z0-9A-Z]((?:[\-_.]|[a-z0-9A-Z]){0,253}[a-z0-9A-Z])?/)?[a-z0-9A-Z]((?:[\-_.]|[a-z0-9A-Z]|){0,62}[a-z0-9A-Z])?$`)
-var valueRegexp = regexp.MustCompile(`^([a-z0-9A-Z](?:[\-_.]|[a-z0-9A-Z]){0,62})?[a-z0-9A-Z]$`)
+var valueRegexp = regexp.MustCompile(`^(([a-z0-9A-Z](?:[\-_.]|[a-z0-9A-Z]){0,62})?[a-z0-9A-Z]$|$)`)
 
 func ValidateResourceLabels(labels map[string]interface{}) (bool, error) {
 	for k, v := range labels {

diff --git a/hcloud/labels_test.go b/hcloud/labels_test.go
@@ -13,6 +13,7 @@ func TestCheckLabels(t *testing.T) {
 			"label2.de/hallo":           "1correct2.de",
 			"label3-test.de/hallo.welt": "233344444443",
 			"d/d":                       "d",
+			"empty/label":               "",
 		}
 
 		ok, err := ValidateResourceLabels(labelMap)