feat: initialize client && request #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
FGYFFFF
reviewed
May 13, 2024
client.go
Outdated
| } | ||
|
|
||
| func New() *Client { | ||
| c, _ := client.NewClient() |
There was a problem hiding this comment.
能把 err 返回出去吗?或者再搞个 mustNew，有error 就 panic
FGYFFFF
reviewed
May 13, 2024
| return c | ||
| } | ||
|
|
||
| func (c *Client) SetQueryString(query string) *Client { |
There was a problem hiding this comment.
SetQueryString 可以给个示例用法吗
There was a problem hiding this comment.
SetQueryString() 是 hertz Request 的原始 API，可以直接转换一下就行https://github.com/cloudwego/hertz/blob/develop/pkg/protocol/request.go#L457
FGYFFFF
reviewed
May 13, 2024
| return c | ||
| } | ||
|
|
||
| func (c *Client) SetHeader(header, value string) *Client { |
There was a problem hiding this comment.
有些 header 有 k-[]v的形式，包括上面的query，可以考虑支持下这种数组类型
feat:improve request
feat:add some api
FGYFFFF
reviewed
May 23, 2024
| client *client.Client | ||
| } | ||
|
|
||
| type ( |
There was a problem hiding this comment.
middleware 可以不用支持， hertz client 本身就有 mw 能力，可以把 hertz client mw 以配置的形式注入，就别在 封装的这一层再搞一层 Middleware 了
There was a problem hiding this comment.
看了下面这个 Middleware 是在用来创建 hertz 的 Request；这块进行不要对外暴露就好，保证easy_http 内部可用就好
FGYFFFF
reviewed
May 23, 2024
client.go
Outdated
|
|
||
| } | ||
|
|
||
| func (c *Client) SetXFormData() *Client { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
feat: initialize client && request