Identity-mapped pagetable support (UEFI boot) #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
master
branch
4 times, most recently
from
902379a
to
8eb79fd
Compare
sarahspberrypi
force-pushed
the
master
branch
from
8eb79fd
to
141bd32
Compare
jounathaen
reviewed
Sep 25, 2023
src/arch/x86_64/kernel/mod.rs
Outdated
| boot_info().hardware_info.phys_addr_range.start as usize | ||
| } | ||
|
|
||
| pub fn is_uefi() -> Result<(), ()> { |
There was a problem hiding this comment.
Why you don't just return a bool?
jounathaen
reviewed
Sep 25, 2023
| - reserved_space) | ||
| .align_down(LargePageSize::SIZE as usize) | ||
| }; | ||
| // if !crate::arch::x86_64::kernel::is_uefi() { |
There was a problem hiding this comment.
This probably needs to be removed 🙂
jounathaen
reviewed
Nov 12, 2023
src/arch/x86_64/mm/paging.rs
Outdated
| @@ -64,6 +70,16 @@ unsafe fn recursive_page_table() -> RecursivePageTable<'static> { | |||
| } | |||
| } | |||
|
|
|||
| unsafe fn identity_mapped_page_table() -> OffsetPageTable<'static> { | |||
There was a problem hiding this comment.
I'd appreciate a short doc comment, as I think it is not 100% obvious what the function is doing.
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
…t page writable Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
… available) + minor inconsistency fixes (e.g., Size4KiB and BasePageSize being used simultaneously)
…tside of forbidden range
…tions accordingly
…apted to that as well
…ADT) and parse the Fixed ACPI Description Table (FADT) (parsing in itself is successful but it still breaks because of a deallocate)
…s (currently only one core supported)
…s (currently only one core supported)
sarahspberrypi
force-pushed
the
master
branch
from
4c235e5
to
c444c99
Compare
…g for UEFI ACPI tables since that's already given
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OG: 9b8db51