Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearify license text, add workround to use raw-cpuid #166

Merged
merged 3 commits into from Feb 3, 2021

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented Feb 2, 2021

The workaround should solve issue #164 and is only necessry until gz/rust-x86#71 is accepted.

The workaround should solve issue hermit-os#164 and
is only necessry until gz/rust-x86#71 is accepted.
Since today, the maintainer supports the latest version of raw-cpuid.
However, this version is currently not uploaded to crates.io.
@jbreitbart
Copy link
Contributor

Why do we need that workaround? Just to close #164 ? Is it really worth it or should we just wait until @gz makes a new release of the x86 crate?

@stlankes
Copy link
Contributor Author

stlankes commented Feb 3, 2021

You are right, the crate will come. We are able to wait

@stlankes stlankes closed this Feb 3, 2021
@gz
Copy link

gz commented Feb 3, 2021

Released 0.36, Thanks!

@stlankes
Copy link
Contributor Author

stlankes commented Feb 3, 2021

@gz I didn't want to put any pressure on you. Thanks for the fast response.

@stlankes stlankes reopened this Feb 3, 2021
@stlankes
Copy link
Contributor Author

stlankes commented Feb 3, 2021

bors r+

bors bot added a commit that referenced this pull request Feb 3, 2021
166: clearify license text, add workround to use raw-cpuid r=stlankes a=stlankes

The workaround should solve issue #164 and is only necessry until gz/rust-x86#71 is accepted.

Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
@bors
Copy link
Contributor

bors bot commented Feb 3, 2021

Build failed:

@stlankes
Copy link
Contributor Author

stlankes commented Feb 3, 2021

bors r+

@bors bors bot merged commit 18cbf90 into hermit-os:master Feb 3, 2021
simonschoening pushed a commit to simonschoening/libhermit-rs that referenced this pull request Aug 26, 2021
166: clearify license text, add workround to use raw-cpuid r=stlankes a=stlankes

The workaround should solve issue hermit-os#164 and is only necessry until gz/rust-x86#71 is accepted.

Co-authored-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants