-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property Views #732
Merged
Merged
Property Views #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoseFx
force-pushed
the
issue/646-property-view-aggregate
branch
from
April 16, 2024 18:05
c5232e7
to
ea1daa4
Compare
FoseFx
force-pushed
the
issue/646-property-view-aggregate
branch
from
April 24, 2024 10:01
33b36a7
to
df41811
Compare
FoseFx
force-pushed
the
issue/646-property-view-aggregate
branch
from
May 2, 2024 13:32
e93e9d3
to
573bab8
Compare
FoseFx
requested review from
MaxSchaefer and
PaulKalho
and removed request for
a team
May 12, 2024 19:06
PaulKalho
requested changes
May 16, 2024
services/property-svc/internal/property-view/commands/v1/update_property_view_rule.go
Outdated
Show resolved
Hide resolved
...s/property-svc/internal/property-view/projections/task_views_postgres/task_views_postgres.go
Outdated
Show resolved
Hide resolved
...s/property-svc/internal/property-view/projections/task_views_postgres/task_views_postgres.go
Outdated
Show resolved
Hide resolved
…ate_property_view_rule.go Co-authored-by: Paul Kalhorn <67231903+PaulKalho@users.noreply.github.com>
…k_views_postgres/task_views_postgres.go Co-authored-by: Paul Kalhorn <67231903+PaulKalho@users.noreply.github.com>
…k_views_postgres/task_views_postgres.go Co-authored-by: Paul Kalhorn <67231903+PaulKalho@users.noreply.github.com>
Co-authored-by: Paul Kalhorn <67231903+PaulKalho@users.noreply.github.com>
PaulKalho
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, we should still take care of this one thing in the projection.
...s/property-svc/internal/property-view/projections/task_views_postgres/task_views_postgres.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #647
#646