Update github.com/rubenv/sql-migrate

[howardjohn]

What this PR does / why we need it:
Updates the dependency on github.com/rubenv/sql-migrate. This drops the total LOC imported by this library from 13.7M to 11.9M due to dropping and import on github.com/go-kit/kit.
Fixes #9770

See prometheus/common#255 for more information on why this may be important
Special notes for your reviewer:
Note: for this dependency there are no tags, so master was used. According to the author in rubenv/sql-migrate#158, there will never be a breaking change to this library, so it should be safe to update.

If applicable:

• this PR contains documentation
• this PR contains unit tests
• this PR has been tested for backwards compatibility

[cndoit18]

Hello
PRs must be linked to an existing issue. If none exists, may you please open one explaining the issue and expected outcome?
Please also write tests to test and verify this PR fixes your issue. Thanks.

[howardjohn]

@cndoit18 I opened #9770 which this fixes. I am not sure its relevant to add a test, this is not a behavioral issue but rather an issue that we are importing too many things.

[howardjohn]

Any feedback on what is needed to get this merged?

[bacongobbler]

Note: for this dependency there are no tags, so master was used. According to the author in rubenv/sql-migrate#158, there will never be a breaking change to this library, so it should be safe to update.

While I understand the sentiment, we have been burned by similar arguments made in the past.

We will have to check the changes made upstream to verify. As this doesn't propose any changes to Helm's behavior and it introduces a low-to-moderate level of risk, it is low in the priority queue. but it is slated for the next Helm release which is scheduled for September 8th, so it will be reviewed before that time.

Thanks for being patient.

[howardjohn]

I would encourage you to reconsider the priority, as the change is quite small and the impact of this change extends beyond Helm, as you are importing a gigantic library, any consumers of helm as a library are also required to import it, and all importers of that library, and so on.

A considerable effort across the golang ecosystem has been made to fix this bloated dependency problem, but it requires buy-in from everyone.

[howardjohn]

I didn't intentionally remove this, go mod tidy wants to remove it

[bacongobbler]

should be good to go after a rebase.

[howardjohn]

@bacongobbler thanks, should be good to go now

[bacongobbler]

Sorry, forgot to mention yesterday. Due to the code size, as per policy this will need another maintainer's sign-off before we can merge.

https://github.com/helm/helm/blob/main/CONTRIBUTING.md#size-labels

[howardjohn]

Sorry, forgot to mention yesterday. Due to the code size, as per policy this will need another maintainer's sign-off before we can merge.

https://github.com/helm/helm/blob/main/CONTRIBUTING.md#size-labels

Fair enough, although the doc does say ignoring generated code - the change is 2 lines of real change and the rest is generated

[hickeyma]

LGTM, thanks @howardjohn