Bump github.com/spf13/cobra from 1.1.1 to 1.1.2 #9350
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.1.2. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@v1.1.1...v1.1.2) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
helm-bot
added
the
size/XS
|
This Cobra release may have needed to be a 2.0 because it no longer supports Go < 1.14. This has been brought to the attention of the maintainers (spf13/cobra#1232 (comment)). I'm not sure what the maintainers will do about this. That being said, the 1.1.2 release should be safe for Helm.
|
|
@marckhouzam Because of the PowerShell completion, is this something for Helm v2.6? I'm surprised to see a feature is in a patch release. Was that intentional? Go 1.14 isn't supported by the Go community. The latest 2 minor releases is all they support. In the Go community it's not unusual to drop support for older unsupported versions of Go. Other imports we use do it. I'm not suggesting it's right or wrong.... rather that it's normal. |
I hadn't even realized! But yes that's a mistake, if not a 2.0 it should at least have been a 1.2 release.
👍 |
|
I will release cobra v1.1.3 with the >= go1.14 requirement reverted. No need for a v1.2 or v2.0 release. |
Thanks @anthonyfok taking to time to answer. |
AFAIK. there are no new features in the v1.1.2 or v1.1.3 from the v1.1.1 release. PowerShell completion support was already in v1.1.1, and this feature was enhanced in v1.1.2 with no change to API. (Please correct me if I am wrong.) The artificial bump to |
|
You are correct that the powershell completion existed in 1.1.1 and has kept the same API in 1.1.3, although it has been greatly improved in its behavior ('greatly' may be a question of opinion😁). |
I totally agree that it is greatly improved too, and that was my main motivation for releasing v1.1.2 to facilitate its inclusion in Debian 11 (entering freeze) and in Hugo. |
|
Superseded by #9355. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/spf13/cobra-1.1.2
branch
Bumps github.com/spf13/cobra from 1.1.1 to 1.1.2.
Release notes
Sourced from github.com/spf13/cobra's releases.
Changelog
Sourced from github.com/spf13/cobra's changelog.
Commits
7f95502Update CHANGELOG.md for v1.1.207445eaCopyedit shell-completion related documentationb73b344ci: add GitHub Actions workflow 'Test' (#1339)652c755Use golangci-lint (#1044)1d71ff0Deprecate Go < 1.14 (#1323)1135bdeUpdate gopkg.in/yaml.v2 to v2.4.09df156eCobra User Contract (#1292)ff416adRevert "Add the ability to specify a filePostpender in GenMarkdownTreeCustom ...23a6174Add the ability to specify a filePostpender in GenMarkdownTreeCustom (#1270)4384b91Bump license year to 2021 in golden files (#1309)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)