fix(exit code): fix the return exit code 0 if subcommand excuted failed #8511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, this error would be better resolved in the dependency library
cobra
and i am also trying to fix this issue ofcobra
.I read the code of other projects using
cobra
likekubectl , github cli
and these project solved this problem.spf13/cobra#1157
I think the way that
kubectl
used is better.kubectl
addsRun
function for those commands with subcommands:https://github.com/kubernetes/kubernetes/blob/8a3fc2d7e2043bc980bb5301d2f4292020f1a2dd/staging/src/k8s.io/kubectl/pkg/cmd/get/get.go#L155-L170
Therefore, I add empty
Run function
for commands with subcommands.(dependency,get,plugin,repo,search,show).Everything is ok.Close: #8286
Signed-off-by: Dong Gang dong.gang@daocloud.io
What this PR does / why we need it:
Fix #8286
Special notes for your reviewer:
If applicable: