Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/asaskevich/govalidator #13031

Merged
merged 1 commit into from
May 14, 2024

Conversation

shahar-h
Copy link
Contributor

What this PR does / why we need it:
Update github.com/asaskevich/govalidator to latest version. Current version is 3 years old and doesn't appear anymore in pkg.go.dev

Special notes for your reviewer:
There are no changes in used functions: IsEmail, IsURL and IsRequestURL.

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There don't appear to be any changes to the code parts that Helm uses.

@mattfarina mattfarina added this to the 3.16.0 milestone May 14, 2024
@mattfarina mattfarina merged commit ee49972 into helm:main May 14, 2024
5 checks passed
@shahar-h shahar-h deleted the update-go-validator branch May 14, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants