Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testdata PKI with keys that have validity until 3393 (closes #12880) #12971

Merged
merged 1 commit into from May 8, 2024

Conversation

dirkmueller
Copy link
Contributor

The ca.crt had to be regenerated because there was no ca.key. Added new ca.key so that going forward only the certs need to be updated.

What this PR does / why we need it:

replaces the testing PKI with one that has extended validity (50000 days, or until 3393).

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

…lm#12880)

The ca.crt had to be regenerated because there was no ca.key. Added
new ca.key so that going forward only the certs need to be updated.

Signed-off-by: Dirk Müller <dirk@dmllr.de>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2024
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattfarina mattfarina merged commit cf823d4 into helm:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants