helm uninstall

[sjeandeaux]

What this PR does / why we need it:

The goal is to have the same behaviour with or without dry-run with --ignore-not-found on uninstall.

I am developping a CD pipeline:

• on pull request, it executes a dry-run but it fails with --ignore-not-found even if the release is not found
• on merge on default branch, it executes and succeeds even if the release is not found which what we expect

The fact is the pull request will be blocked due a failed build. The dry-run does not have the same behaviour.

Special notes for your reviewer:

If applicable:

• this PR contains documentation
• this PR contains unit tests
• this PR has been tested for backwards compatibility

refs #12970

[eddymoulton]

Successfully tested this locally with the below process.
The standard dry run output (without --ignore-not-found) still differs from the regular output, but I'm happy that this PR fixes the issue it set out to fix.

helm install hello-world examples/hello-world

# Check behaviour is the same when a release exists
./bin/helm uninstall --dry-run --ignore-not-found hello-world
./bin/helm uninstall --ignore-not-found hello-world

# Check behaviour when the release doesn't exist (this change)
./bin/helm uninstall --dry-run --ignore-not-found hello-world
./bin/helm uninstall --ignore-not-found hello-world

# Check the behaviour without `--ignore-not-found`
./bin/helm uninstall --dry-run hello-world
./bin/helm uninstall hello-world

Before

➜  helm git:(main) helm install hello-world examples/hello-world
NAME: hello-world
LAST DEPLOYED: Mon May 13 14:20:38 2024
NAMESPACE: helm-12968
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace helm-12968 -l "app.kubernetes.io/name=hello-world,app.kubernetes.io/instance=hello-world" -o jsonpath="{.items[0].metadata.name}")
  export CONTAINER_PORT=$(kubectl get pod --namespace helm-12968 $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
  echo "Visit http://127.0.0.1:8080 to use your application"
  kubectl --namespace helm-12968 port-forward $POD_NAME 8080:$CONTAINER_PORT
➜  helm git:(main) ./bin/helm uninstall --dry-run --ignore-not-found hello-world
release "hello-world" uninstalled
➜  helm git:(main) ./bin/helm uninstall --ignore-not-found hello-world
release "hello-world" uninstalled
➜  helm git:(main) ./bin/helm uninstall --dry-run --ignore-not-found hello-world
Error: release: not found
➜  helm git:(main) ./bin/helm uninstall --ignore-not-found hello-world
release "hello-world" uninstalled
➜  helm git:(main) ./bin/helm uninstall --dry-run hello-world
Error: release: not found
➜  helm git:(main) ./bin/helm uninstall hello-world
Error: uninstall: Release not loaded: hello-world: release: not found

After

➜  helm git:(helm-uninstall-dry-run) helm install hello-world examples/hello-world
NAME: hello-world
LAST DEPLOYED: Mon May 13 14:16:46 2024
NAMESPACE: helm-12968
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
1. Get the application URL by running these commands:
  export POD_NAME=$(kubectl get pods --namespace helm-12968 -l "app.kubernetes.io/name=hello-world,app.kubernetes.io/instance=hello-world" -o jsonpath="{.items[0].metadata.name}")
  export CONTAINER_PORT=$(kubectl get pod --namespace helm-12968 $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
  echo "Visit http://127.0.0.1:8080 to use your application"
  kubectl --namespace helm-12968 port-forward $POD_NAME 8080:$CONTAINER_PORT
➜  helm git:(helm-uninstall-dry-run) ./bin/helm uninstall --dry-run --ignore-not-found hello-world
release "hello-world" uninstalled
➜  helm git:(helm-uninstall-dry-run) ./bin/helm uninstall --ignore-not-found hello-world
release "hello-world" uninstalled
➜  helm git:(helm-uninstall-dry-run) ./bin/helm uninstall --dry-run --ignore-not-found hello-world
release "hello-world" uninstalled
➜  helm git:(helm-uninstall-dry-run) ./bin/helm uninstall --ignore-not-found hello-world
release "hello-world" uninstalled
➜  helm git:(helm-uninstall-dry-run) ./bin/helm uninstall --dry-run hello-world
Error: release: not found
➜  helm git:(helm-uninstall-dry-run) ./bin/helm uninstall hello-world
Error: uninstall: Release not loaded: hello-world: release: not found