Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the namespace on the kube client when calling Init #12940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

toneill818
Copy link

closes #8685

What this PR does / why we need it:
When using the Init function for an action.Configuration the passed in namespace is not set on the kube.Client.

Special notes for your reviewer:

If applicable:

  • [ X ] this PR contains documentation
  • [ X ] this PR contains unit tests
  • [ ] this PR has been tested for backwards compatibility

Signed-off-by: Thomas O'Neill <toneill818@gmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2024
Copy link
Contributor

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go SDK upgrade performing actions in the wrong namespace
2 participants