Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error details when a dependent chart's version cannot be found in a repo #12934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Apr 10, 2024

What this PR does / why we need it:

This is about the error in case a chart version does not (yet) exist in the repo. Example:

dependencies:
  - name: abcd
    version: "0.18.0-does-not-exist"
    repository: "https://example.com/helmrepo"

Before:

$ helm dependency update
[...]
Error: can't get a valid version for repositories abcd. Try changing the version constraint in Chart.yaml

The error message mistakenly refers to "repositories", but the printed value is a chart name. Also, since abcd here isn't quoted, it could be mistaken as being a regular word in the error message sentence.

After:

$ helm dependency update
[...]
Error: can't get a valid version for 1 subchart(s): "abcd" (repository "https://example.com/helmrepo", version "0.18.0-does-not-exist"). Make sure a matching chart version exists in the repo, or change the version constraint in Chart.yaml

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

… a repo

Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2024
Copy link
Contributor

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants