Drop unused field. #12924
Open
Drop unused field. #12924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
pull-request-size
bot
added
the
size/S
robertsirc
approved these changes
Apr 15, 2024
While no longer used by the helm code, this field is part of the API exposed to helm charts as part of the .Capabilities struct. Signed-off-by: Marcin Owsiany <marcin@redhat.com>
|
Thanks for taking a look @robertsirc ! Removed one questionable comment line that I had added, and explained the situation a bit more in the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
it seems that
manifestFile.apisis a write-only field, and can safely be removed.Special notes for your reviewer:
The
Capabilities.APIVersionsfield, while no longer used on its own by the Helm code directly, remains exposed to helm charts as part of the.Capabilitiesstruct, which may well depend on it, so it must stay untouched.Introducing new versions of functions with one less argument seems like an overkill, so I just replaced the argument names with an underscore.
If applicable: