Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lint): Tests for lint flag --full-path #12923

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Bhargav-InfraCloud
Copy link
Contributor

@Bhargav-InfraCloud Bhargav-InfraCloud commented Apr 4, 2024

What this PR does / why we need it:

The flag --full-path enables printing full paths in linter warnings and errors which is added in #12496. This PR has tests for that PR.

Related to #11365

Special notes for your reviewer:

Currently, this PR has the commits for both the feature and tests making it size/XXL. Once #12496 is merged, this can be used only for tests. Else, please review only the test commit under this PR.

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

The flag --full-path enables printing full paths in linter warnings
and errors.

Fixes helm#11365

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Related to helm#12496

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant