Implement helm.sh/resource-deletion-policy annotation to override deletion cascade per resource #12917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
|
Not to be difficult but shouldn't this have some testing? |
Danil-Grigorev
force-pushed
the
override-deletion-policy
branch
from
9ceed20
to
076afaa
Compare
pull-request-size
bot
added
size/L
Danil-Grigorev
force-pushed
the
override-deletion-policy
branch
from
076afaa
to
769742a
Compare
…etion cascade per resource Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
|
Hi @robertsirc yeah, tests sound good. Just added some, can this be |
|
Hey @Danil-Grigorev this is a great question if you could join us for the weekly developer meeting on Thursday and ask one of their maintainers. I was just helping read through these and as i looked at all the code you added I wanted to question if it made sense for us to write up some test as we could ensure we are getting the functionality you added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Helm uninstall command allows to provider an optional
--cascadeflag to specify a deletion policy to use for all resources. In some cases this policy has to beforeground, to ensure the ownership resources are deleted in order, and the deletion is finished until the next hook phase is executed.To achieve this, a new annotation is provided,
helm.sh/resource-deletion-policy. When it is set on the resource, the policy from the value is applied on delete request, regardless of the--cascadeflag value.Special notes for your reviewer:
If applicable:
(backwards compatibility is ensured as it is just adding an annotation. Previous releases would ignore it)