Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cobra to 1.3.0 #10484

Closed
wants to merge 1 commit into from
Closed

Conversation

marckhouzam
Copy link
Member

What this PR does / why we need it:

Move to the latest Cobra release.
It keeps us up-to-date but also brings two fixes of value to Helm:

Special notes for your reviewer:

I don't know why dependabot didn't trigger in this case.

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 19, 2021
Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Merge when ready.

@mattfarina mattfarina added this to the 3.8.0 milestone Dec 21, 2021
@mattfarina
Copy link
Collaborator

@marckhouzam merged a different PR that created a conflict. Sorry about that.

Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
@marckhouzam
Copy link
Member Author

@mattfarina Rebased

@marckhouzam
Copy link
Member Author

marckhouzam commented Dec 21, 2021

Let's instead use the PR that dependabot finally opened: #10491

@marckhouzam marckhouzam deleted the feat/bumpCobra130 branch December 21, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants