Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: helm uninstall dry-run and ignore-not-found behaviour #12970

Open
sjeandeaux opened this issue Apr 20, 2024 · 2 comments
Open

bug: helm uninstall dry-run and ignore-not-found behaviour #12970

sjeandeaux opened this issue Apr 20, 2024 · 2 comments
Labels
bug Categorizes issue or PR as related to a bug. in progress

Comments

@sjeandeaux
Copy link

helm uninstall --dry-run --ignore-not-found fails if the release does not exist.
helm uninstall --ignore-not-found does not fail if the release does not exist.

We should get the same behaviour.

Output of helm version:

❯ helm version
version.BuildInfo{Version:"v3.14.4", GitCommit:"81c902a123462fd4052bc5e9aa9c513c4c8fc142", GitTreeState:"clean", GoVersion:"go1.22.2"}

Output of kubectl version:

❯ kubectl version
Client Version: v1.29.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.2

Cloud Provider/Platform (AKS, GKE, Minikube etc.): Any
@sjeandeaux sjeandeaux mentioned this issue Apr 20, 2024
Open
3 tasks
sjeandeaux added a commit to sjeandeaux/helm that referenced this issue Apr 23, 2024
@sjeandeaux
helm uninstall
4485702 
The goal is to have the same behaviour with or without dry-run with --ignore-not-found

close helm#12970

Signed-off-by: Stephane Jeandeaux <stephane.jeandeaux@gmail.com>
@gjenkins8 gjenkins8 added bug Categorizes issue or PR as related to a bug. in progress labels Apr 27, 2024
@gjenkins8
Copy link
Contributor

thanks for the report and PR.

@yxxhero
Copy link
Member

yxxhero commented May 6, 2024

@gjenkins8 PR is ready. could you have an review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug. in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gjenkins8 @sjeandeaux @yxxhero