Skip to content

Commit

Permalink
Add a note about --dry-run displaying secrets
Browse files Browse the repository at this point in the history
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit a23dd9e)
  • Loading branch information
mattfarina committed Mar 13, 2024
1 parent 1a7330f commit f03cc04
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
6 changes: 5 additions & 1 deletion cmd/helm/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@ And in the following example, 'foo' is set to '{"key1":"value1","key2":"bar"}':
$ helm install --set-json='foo={"key1":"value1","key2":"value2"}' --set-json='foo.key2="bar"' myredis ./redis
To check the generated manifests of a release without installing the chart,
the '--debug' and '--dry-run' flags can be combined.
the --debug and --dry-run flags can be combined.
The --dry-run flag will output all generated chart manifests, including Secrets
which can contain sensitive values. Please carefully consider how and when this
flag is used.
If --verify is set, the chart MUST have a provenance file, and the provenance
file MUST pass all verification steps.
Expand Down
4 changes: 4 additions & 0 deletions cmd/helm/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ parameters, and existing values will be merged with any values set via '--values
or '--set' flags. Priority is given to new values.
$ helm upgrade --reuse-values --set foo=bar --set foo=newbar redis ./redis
The --dry-run flag will output all generated chart manifests, including Secrets
which can contain sensitive values. Please carefully consider how and when this
flag is used.
`

func newUpgradeCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
Expand Down

0 comments on commit f03cc04

Please sign in to comment.