-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HIP 7 to document subprojects #156
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matt Farina <matt@mattfarina.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the structure of using a yaml file.
Since this is a hip, shouldn't the modifications it proposes not be part of the same PR? The hip workflow states that a hip can be merged as approved (as a proposal) but not yet be accepted (as something that will be accepted as a modification). Not a big deal here, but I thought it was an opportunity to clarify the hip workflow.
- https://github.com/helm/helm-www | ||
- name: Community Management | ||
owners: | ||
- karenhchu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the helm/community repo be listed here or is it something different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The community repo is managed by the org maintainers right now. Karen is doing other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marckhouzam or anyone else... what would be a good way to document the community repo being owned by the org maintainers? Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
ownersLink: https://raw.githubusercontent.com/helm/community/master/MAINTAINERS.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Only one note, which would be a follow-up.
|
||
## References | ||
|
||
* [Helm Governance](https://github.com/helm/community/blob/master/governance/governance.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to clarify the language in the governance doc as well - it references "subprojects", "sub-groups" and "subteam".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at the governance. The item sub-groups means that the org maintainers create categories like "subprojects". It's not meant to refer to subprojects.
"subteam" should be fixed but I think that can be a different PR. It's something we didn't catch during the initial reviews of the governance.
Signed-off-by: Matt Farina <matt.farina@suse.com>
@scottrigby @bacongobbler @marckhouzam can you take another pass at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (although I'm not a maintainer)
@@ -0,0 +1,58 @@ | |||
subprojects: | |||
- name: Helm Core | |||
ownersLink: https://raw.githubusercontent.com/helm/helm/master/OWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link should be updated with the new name of the "main" branch
repos: | ||
- https://github.com/helm/chartmuseum | ||
- name: helm-2to3 | ||
ownersLink: https://raw.githubusercontent.com/helm/helm-2to3/master/OWNERS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default branch has also become "main" for helm 2to3
The PR needs a rebase @mattfarina |
Hey there! Just checking in to see what's the status here. Are there plans to continue this work, or has it stalled out? If the work here has stalled out, we'd appreciate it if you could rebase the PR and mark the HIP as "deferred" (see https://github.com/helm/community/blob/main/hips/hip-0001.md#proposal-review--resolution). Once this picks back up we can either re-assign it as a "draft" or "rejected", should this proposal not be a good idea for whichever reason. Thanks! |
ping |
cc @helm/helm-org-maintainers
This is designed to document the subprojects, their maintainers, and their repos. We could expand this to later document more about the subprojects.