Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HIP 7 to document subprojects #156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattfarina
Copy link
Contributor

cc @helm/helm-org-maintainers

This is designed to document the subprojects, their maintainers, and their repos. We could expand this to later document more about the subprojects.

@mattfarina mattfarina requested a review from a team November 9, 2020 16:18
@helm-bot helm-bot added the size/L label Nov 9, 2020
Signed-off-by: Matt Farina <matt@mattfarina.com>
Copy link
Member

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the structure of using a yaml file.

Since this is a hip, shouldn't the modifications it proposes not be part of the same PR? The hip workflow states that a hip can be merged as approved (as a proposal) but not yet be accepted (as something that will be accepted as a modification). Not a big deal here, but I thought it was an opportunity to clarify the hip workflow.

hips/hip-0007.md Outdated Show resolved Hide resolved
- https://github.com/helm/helm-www
- name: Community Management
owners:
- karenhchu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the helm/community repo be listed here or is it something different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The community repo is managed by the org maintainers right now. Karen is doing other things.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marckhouzam or anyone else... what would be a good way to document the community repo being owned by the org maintainers? Any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about
ownersLink: https://raw.githubusercontent.com/helm/community/master/MAINTAINERS.md

hips/hip-0007.md Show resolved Hide resolved
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Only one note, which would be a follow-up.


## References

* [Helm Governance](https://github.com/helm/community/blob/master/governance/governance.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to clarify the language in the governance doc as well - it references "subprojects", "sub-groups" and "subteam".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at the governance. The item sub-groups means that the org maintainers create categories like "subprojects". It's not meant to refer to subprojects.

"subteam" should be fixed but I think that can be a different PR. It's something we didn't catch during the initial reviews of the governance.

Signed-off-by: Matt Farina <matt.farina@suse.com>
@mattfarina
Copy link
Contributor Author

@scottrigby @bacongobbler @marckhouzam can you take another pass at this?

Copy link
Member

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although I'm not a maintainer)

@@ -0,0 +1,58 @@
subprojects:
- name: Helm Core
ownersLink: https://raw.githubusercontent.com/helm/helm/master/OWNERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should be updated with the new name of the "main" branch

repos:
- https://github.com/helm/chartmuseum
- name: helm-2to3
ownersLink: https://raw.githubusercontent.com/helm/helm-2to3/master/OWNERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default branch has also become "main" for helm 2to3

@marckhouzam
Copy link
Member

The PR needs a rebase @mattfarina

@bacongobbler
Copy link
Member

Hey there! Just checking in to see what's the status here. Are there plans to continue this work, or has it stalled out?

If the work here has stalled out, we'd appreciate it if you could rebase the PR and mark the HIP as "deferred" (see https://github.com/helm/community/blob/main/hips/hip-0001.md#proposal-review--resolution). Once this picks back up we can either re-assign it as a "draft" or "rejected", should this proposal not be a good idea for whichever reason.

Thanks!

@bacongobbler
Copy link
Member

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants