Peform single push on upload in case of multiple releases #314
Conversation
amalgamm
force-pushed
the
single_push_on_upload
branch
from
8157b4c
to
5fd540c
Compare
|
@davidkarlsen can you have a look at this pr? |
|
I just realized that my PR is a duplicate of this one, and this one is better as it fixes the tests. #336 Can we have someone take a look at this PR please ? |
|
does anyone can provide some manual tests on this? @amalgamm @gaelgatelement and show the logs and maybe the ci job |
|
I'm using this fork in our own CI runs : https://github.com/vector-im/ess-starter-edition-core/actions/runs/6624187779 |
|
thanks @gaelgatelement |
|
tested on my side and seems to work fine :) |
|
Hi! I just run into the issue this PR fixes, it'd be cool to have it merged! |
Signed-off-by: Ivan Panteleev <ispanteleev@gmail.com> Signed-off-by: amalgamm <ispanteleev@gmail.com>
amalgamm
force-pushed
the
single_push_on_upload
branch
from
85d7dad
to
8ea3170
Compare
|
@cpanato I think I fixed the lint. Sorry it took so long |
|
Did you test the case with |
I didn't but I think this case is covered by tests |
|
please merge |
|
Any way to get this merged? @cpanato |
Resolves the problem mentioned in this PR
Lets say you want to upload more than one release and place it near the index file. After the first push your second push will be rejected with an error "Updates were rejected because a pushed branch tip is behind its remote". So either you need to pull changes before push another release or push all releases once in the end of upload action.
In case of pulling changes and pushing every release separately you'll face github will launch as many "pages build and deployment" actions as there are new releases you want to upload. All except one will be canceled, but the list of actions will look like a mess.
So the most efficient way is to make single push in the end of upload.