Add --skip-upload input with latest helm/chart-releaser-action #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: acuD1 <arsciand@student.42.fr>
Signed-off-by: acuD1 <arsciand@student.42.fr>
|
Hi, do you want me to rebase this branch to solve conflicts ? Greetings. |
|
@acuD1 able to fix the conflicts? I’ve been using your revision and it works well |
|
@jasonmoore2k rebased, instead of two Maybe there is a more elegant way to doing that, but it's less code added ;) |
|
lgtm |
|
can you please rebase? thanks |
|
@cpanato rebased. |
|
@davidkarlsen PTAL |
davidkarlsen
approved these changes
Nov 19, 2023
|
Could you create a release/tag with these changes? @cpanato |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature that allows skipping the
upload_indexparts in this action. The main motivation behind this change is to enable the use of OCI-based repositories for Helm with the Github Container Registry without managing the upload process of theindex.yamlfile.Changes Made:
Updated
README.md: Added information about the new--skip-uploadoption and its purpose.Updated
action.yaml: Added the skip_upload input parameter to the action file.Updated
cr.sh:--skip-uploadoption to the script's usage information.main()function to respect the skip_upload option.Ensured thatThis is handled directly in theupdate_indexis only called if theskip_uploadoption is not set.update_indexfunction now.skip_uploadvariable properly and passed it as an argument when callingupdate_index.