Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated charts-repo-url option #123

Merged
merged 2 commits into from Nov 30, 2022
Merged

Remove deprecated charts-repo-url option #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abc473c
Remove deprecated charts-repo-url option
jftanner Sep 29, 2022
360ee07
empty commit to trigger ci
davidkarlsen Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions action.yml
View file
Open in desktop
Expand Up @@ -16,9 +16,6 @@ inputs:
description: The charts directory
required: false
default: charts
charts_repo_url:
description: "The GitHub Pages URL to the charts repo (default: https://<owner>.github.io/<repo>)"
required: false
install_dir:
description: 'Where to install the cr tool'
required: false
Expand All @@ -44,10 +41,6 @@ runs:
args+=(--config "${{ inputs.config }}")
fi

if [[ -n "${{ inputs.charts_repo_url }}" ]]; then
args+=(--charts-repo-url "${{ inputs.charts_repo_url }}")
fi

if [[ -z "${{ inputs.install_dir }}" ]]; then
install="$RUNNER_TOOL_CACHE/cr/${{ inputs.version }}/$(uname -m)"
echo "$install" >> "$GITHUB_PATH"
Expand Down
18 changes: 1 addition & 17 deletions cr.sh
View file
Open in desktop
Expand Up @@ -28,7 +28,6 @@ Usage: $(basename "$0") <options>
-v, --version The chart-releaser version to use (default: $DEFAULT_CHART_RELEASER_VERSION)"
--config The path to the chart-releaser config file
-d, --charts-dir The charts directory (default: charts)
-u, --charts-repo-url The GitHub Pages URL to the charts repo (default: https://<owner>.github.io/<repo>)
-o, --owner The repo owner
-r, --repo The repo name
-n, --install-dir The Path to install the cr tool
Expand All @@ -42,7 +41,6 @@ main() {
local charts_dir=charts
local owner=
local repo=
local charts_repo_url=
local install_dir=
local install_only=

Expand Down Expand Up @@ -125,16 +123,6 @@ parse_command_line() {
exit 1
fi
;;
-u|--charts-repo-url)
if [[ -n "${2:-}" ]]; then
charts_repo_url="$2"
shift
else
echo "ERROR: '-u|--charts-repo-url' cannot be empty." >&2
show_help
exit 1
fi
;;
-o|--owner)
if [[ -n "${2:-}" ]]; then
owner="$2"
Expand Down Expand Up @@ -187,10 +175,6 @@ parse_command_line() {
exit 1
fi

if [[ -z "$charts_repo_url" ]]; then
charts_repo_url="https://$owner.github.io/$repo"
fi

if [[ -z "$install_dir" ]]; then
local arch
arch=$(uname -m)
Expand Down Expand Up @@ -278,7 +262,7 @@ release_charts() {
}

update_index() {
local args=(-o "$owner" -r "$repo" -c "$charts_repo_url" --push)
local args=(-o "$owner" -r "$repo" --push)
if [[ -n "$config" ]]; then
args+=(--config "$config")
fi
Expand Down