Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated charts-repo-url option #123

Merged
merged 2 commits into from Nov 30, 2022

Conversation

jftanner
Copy link
Contributor

@jftanner jftanner commented Oct 1, 2022

The --charts-repo option is no longer used, since helm/chart-releaser#144. This PR removes it from the action as well.

Fixes #122.

Signed-off-by: James Tanner-McLeod <james.tanner@tanndev.com>
@jftanner
Copy link
Contributor Author

Thanks for the review @davidkarlsen! Anything else you need from me to merge it?

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
@davidkarlsen davidkarlsen merged commit 89fff88 into helm:main Nov 30, 2022
renovate bot added a commit to teutonet/teutonet-helm-charts that referenced this pull request Jan 9, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[helm/chart-releaser-action](https://togithub.com/helm/chart-releaser-action)
| action | minor | `v1.4.1` -> `v1.5.0` |

---

### Release Notes

<details>
<summary>helm/chart-releaser-action</summary>

###
[`v1.5.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.5.0)

[Compare
Source](https://togithub.com/helm/chart-releaser-action/compare/v1.4.1...v1.5.0)

#### What's Changed

- Skip packaging option - resolves
[#&#8203;108](https://togithub.com/helm/chart-releaser-action/issues/108)
by [@&#8203;gmorse81](https://togithub.com/gmorse81) in
[helm/chart-releaser-action#109
- Remove deprecated charts-repo-url option by
[@&#8203;jftanner](https://togithub.com/jftanner) in
[helm/chart-releaser-action#123
- default action to cr v1.5.0 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#127

#### New Contributors

- [@&#8203;gmorse81](https://togithub.com/gmorse81) made their first
contribution in
[helm/chart-releaser-action#109
- [@&#8203;jftanner](https://togithub.com/jftanner) made their first
contribution in
[helm/chart-releaser-action#123

**Full Changelog**:
helm/chart-releaser-action@v1...v1.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/teutonet/teutonet-helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuODQuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq bot pushed a commit to cloudquery/helm-charts that referenced this pull request Jan 26, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [helm/chart-releaser-action](https://togithub.com/helm/chart-releaser-action) | action | minor | `v1.4.1` -> `v1.5.0` |

---

### Release Notes

<details>
<summary>helm/chart-releaser-action</summary>

### [`v1.5.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.5.0)

[Compare Source](https://togithub.com/helm/chart-releaser-action/compare/v1.4.1...v1.5.0)

#### What's Changed

-   Skip packaging option - resolves [#&#8203;108](https://togithub.com/helm/chart-releaser-action/issues/108) by [@&#8203;gmorse81](https://togithub.com/gmorse81) in [helm/chart-releaser-action#109
-   Remove deprecated charts-repo-url option by [@&#8203;jftanner](https://togithub.com/jftanner) in [helm/chart-releaser-action#123
-   default action to cr v1.5.0 by [@&#8203;cpanato](https://togithub.com/cpanato) in [helm/chart-releaser-action#127

#### New Contributors

-   [@&#8203;gmorse81](https://togithub.com/gmorse81) made their first contribution in [helm/chart-releaser-action#109
-   [@&#8203;jftanner](https://togithub.com/jftanner) made their first contribution in [helm/chart-releaser-action#123

**Full Changelog**: helm/chart-releaser-action@v1...v1.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTQuMCJ9-->
kodiakhq bot pushed a commit to cloudquery/helm-charts that referenced this pull request Jan 26, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [helm/chart-releaser-action](https://togithub.com/helm/chart-releaser-action) | action | minor | `v1.4.1` -> `v1.5.0` |

---

### Release Notes

<details>
<summary>helm/chart-releaser-action</summary>

### [`v1.5.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.5.0)

[Compare Source](https://togithub.com/helm/chart-releaser-action/compare/v1.4.1...v1.5.0)

#### What's Changed

-   Skip packaging option - resolves [#&#8203;108](https://togithub.com/helm/chart-releaser-action/issues/108) by [@&#8203;gmorse81](https://togithub.com/gmorse81) in [helm/chart-releaser-action#109
-   Remove deprecated charts-repo-url option by [@&#8203;jftanner](https://togithub.com/jftanner) in [helm/chart-releaser-action#123
-   default action to cr v1.5.0 by [@&#8203;cpanato](https://togithub.com/cpanato) in [helm/chart-releaser-action#127

#### New Contributors

-   [@&#8203;gmorse81](https://togithub.com/gmorse81) made their first contribution in [helm/chart-releaser-action#109
-   [@&#8203;jftanner](https://togithub.com/jftanner) made their first contribution in [helm/chart-releaser-action#123

**Full Changelog**: helm/chart-releaser-action@v1...v1.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTQuMCJ9-->
@joshuasimon-taulia
Copy link

joshuasimon-taulia commented Mar 2, 2023

charts_repo_url is still referenced in the repo documentation. the common use case for this action is to to run cr in a workflow on merge to main branch and upload a chart to a separate github repo. what's the best way to accomplish this now that charts_repo_url has been removed? i see these cli options in the latest (v1.5.0) release of chart-releaser, but they don't seem to be settable by env vars via this action

  -r, --git-repo string                GitHub repository
  -u, --git-upload-url string          GitHub Upload URL (only needed for private GitHub) (default "https://uploads.github.com/")
  -o, --owner string                   GitHub username or organization

creating a cr.yaml file is not practical for reusable workflow users with large numbers of application repositories

@krapie
Copy link
Contributor

krapie commented Apr 11, 2023

As @joshuasimon-taulia mentioned, charts_repo_url is still referenced in latest commit.
Because of this, I had to look for various Issues and PRs in chart-releaser and chart-releaser-action :(

I will update documentation to prevent further usage of charts_repo_url option.

ti-chi-bot bot pushed a commit to PingCAP-QE/ee-apps that referenced this pull request Dec 5, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[helm/chart-releaser-action](https://togithub.com/helm/chart-releaser-action)
| action | minor | `v1.4.1` -> `v1.6.0` |

---

### Release Notes

<details>
<summary>helm/chart-releaser-action
(helm/chart-releaser-action)</summary>

###
[`v1.6.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.6.0)

[Compare
Source](https://togithub.com/helm/chart-releaser-action/compare/v1.5.0...v1.6.0)

#### What's Changed

- Allow to mark the published github release as latest by
[@&#8203;szaimen](https://togithub.com/szaimen) in
[helm/chart-releaser-action#135
- Support actions triggered by a tag by
[@&#8203;luisico](https://togithub.com/luisico) in
[helm/chart-releaser-action#96
- Add flag `skip-existing` to skip upload if release exists by
[@&#8203;xunleii](https://togithub.com/xunleii) in
[helm/chart-releaser-action#134
- bump to use chart-releaser v1.6.0 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#146
- Remove `charts_repo_url` from readme by
[@&#8203;viceice](https://togithub.com/viceice) in
[helm/chart-releaser-action#144
- Remove deprecated `charts_repo_url` option in documentation by
[@&#8203;krapie](https://togithub.com/krapie) in
[helm/chart-releaser-action#137
- Add `changed_charts` and `chart_version` outputs by
[@&#8203;n-oden](https://togithub.com/n-oden) in
[helm/chart-releaser-action#130
- Added: --packages-with-index parameter by
[@&#8203;valeriano-manassero](https://togithub.com/valeriano-manassero)
in
[helm/chart-releaser-action#148
- docs: add skip_existing to README by
[@&#8203;lazyfrosch](https://togithub.com/lazyfrosch) in
[helm/chart-releaser-action#158
- README: Fix default chart-releaser version by
[@&#8203;michalbiesek](https://togithub.com/michalbiesek) in
[helm/chart-releaser-action#155
- Extend `show_help` with `packages-with-index` by
[@&#8203;michalbiesek](https://togithub.com/michalbiesek) in
[helm/chart-releaser-action#160
- Add `--pages-branch` parameter by
[@&#8203;michalbiesek](https://togithub.com/michalbiesek) in
[helm/chart-releaser-action#156
- fix packages_with_index flag by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#172
- bump cr to 1.6.1 and add dependabot config by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#173

#### New Contributors

- [@&#8203;szaimen](https://togithub.com/szaimen) made their first
contribution in
[helm/chart-releaser-action#135
- [@&#8203;luisico](https://togithub.com/luisico) made their first
contribution in
[helm/chart-releaser-action#96
- [@&#8203;xunleii](https://togithub.com/xunleii) made their first
contribution in
[helm/chart-releaser-action#134
- [@&#8203;viceice](https://togithub.com/viceice) made their first
contribution in
[helm/chart-releaser-action#144
- [@&#8203;krapie](https://togithub.com/krapie) made their first
contribution in
[helm/chart-releaser-action#137
- [@&#8203;n-oden](https://togithub.com/n-oden) made their first
contribution in
[helm/chart-releaser-action#130
-
[@&#8203;valeriano-manassero](https://togithub.com/valeriano-manassero)
made their first contribution in
[helm/chart-releaser-action#148
- [@&#8203;lazyfrosch](https://togithub.com/lazyfrosch) made their first
contribution in
[helm/chart-releaser-action#158
- [@&#8203;michalbiesek](https://togithub.com/michalbiesek) made their
first contribution in
[helm/chart-releaser-action#155
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[helm/chart-releaser-action#174

**Full Changelog**:
helm/chart-releaser-action@v1.5.0...v1.6.0

###
[`v1.5.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.5.0)

[Compare
Source](https://togithub.com/helm/chart-releaser-action/compare/v1.4.1...v1.5.0)

#### What's Changed

- Skip packaging option - resolves
[#&#8203;108](https://togithub.com/helm/chart-releaser-action/issues/108)
by [@&#8203;gmorse81](https://togithub.com/gmorse81) in
[helm/chart-releaser-action#109
- Remove deprecated charts-repo-url option by
[@&#8203;jftanner](https://togithub.com/jftanner) in
[helm/chart-releaser-action#123
- default action to cr v1.5.0 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#127

#### New Contributors

- [@&#8203;gmorse81](https://togithub.com/gmorse81) made their first
contribution in
[helm/chart-releaser-action#109
- [@&#8203;jftanner](https://togithub.com/jftanner) made their first
contribution in
[helm/chart-releaser-action#123

**Full Changelog**:
helm/chart-releaser-action@v1...v1.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/PingCAP-QE/ee-apps).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to newrelic/helm-charts that referenced this pull request Jan 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[helm/chart-releaser-action](https://togithub.com/helm/chart-releaser-action)
| action | minor | `v1.3.0` -> `v1.6.0` |

---

### Release Notes

<details>
<summary>helm/chart-releaser-action
(helm/chart-releaser-action)</summary>

###
[`v1.6.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.6.0)

[Compare
Source](https://togithub.com/helm/chart-releaser-action/compare/v1.5.0...v1.6.0)

#### What's Changed

- Allow to mark the published github release as latest by
[@&#8203;szaimen](https://togithub.com/szaimen) in
[helm/chart-releaser-action#135
- Support actions triggered by a tag by
[@&#8203;luisico](https://togithub.com/luisico) in
[helm/chart-releaser-action#96
- Add flag `skip-existing` to skip upload if release exists by
[@&#8203;xunleii](https://togithub.com/xunleii) in
[helm/chart-releaser-action#134
- bump to use chart-releaser v1.6.0 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#146
- Remove `charts_repo_url` from readme by
[@&#8203;viceice](https://togithub.com/viceice) in
[helm/chart-releaser-action#144
- Remove deprecated `charts_repo_url` option in documentation by
[@&#8203;krapie](https://togithub.com/krapie) in
[helm/chart-releaser-action#137
- Add `changed_charts` and `chart_version` outputs by
[@&#8203;n-oden](https://togithub.com/n-oden) in
[helm/chart-releaser-action#130
- Added: --packages-with-index parameter by
[@&#8203;valeriano-manassero](https://togithub.com/valeriano-manassero)
in
[helm/chart-releaser-action#148
- docs: add skip_existing to README by
[@&#8203;lazyfrosch](https://togithub.com/lazyfrosch) in
[helm/chart-releaser-action#158
- README: Fix default chart-releaser version by
[@&#8203;michalbiesek](https://togithub.com/michalbiesek) in
[helm/chart-releaser-action#155
- Extend `show_help` with `packages-with-index` by
[@&#8203;michalbiesek](https://togithub.com/michalbiesek) in
[helm/chart-releaser-action#160
- Add `--pages-branch` parameter by
[@&#8203;michalbiesek](https://togithub.com/michalbiesek) in
[helm/chart-releaser-action#156
- fix packages_with_index flag by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#172
- bump cr to 1.6.1 and add dependabot config by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#173

#### New Contributors

- [@&#8203;szaimen](https://togithub.com/szaimen) made their first
contribution in
[helm/chart-releaser-action#135
- [@&#8203;luisico](https://togithub.com/luisico) made their first
contribution in
[helm/chart-releaser-action#96
- [@&#8203;xunleii](https://togithub.com/xunleii) made their first
contribution in
[helm/chart-releaser-action#134
- [@&#8203;viceice](https://togithub.com/viceice) made their first
contribution in
[helm/chart-releaser-action#144
- [@&#8203;krapie](https://togithub.com/krapie) made their first
contribution in
[helm/chart-releaser-action#137
- [@&#8203;n-oden](https://togithub.com/n-oden) made their first
contribution in
[helm/chart-releaser-action#130
-
[@&#8203;valeriano-manassero](https://togithub.com/valeriano-manassero)
made their first contribution in
[helm/chart-releaser-action#148
- [@&#8203;lazyfrosch](https://togithub.com/lazyfrosch) made their first
contribution in
[helm/chart-releaser-action#158
- [@&#8203;michalbiesek](https://togithub.com/michalbiesek) made their
first contribution in
[helm/chart-releaser-action#155
- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[helm/chart-releaser-action#174

**Full Changelog**:
helm/chart-releaser-action@v1.5.0...v1.6.0

###
[`v1.5.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.5.0)

[Compare
Source](https://togithub.com/helm/chart-releaser-action/compare/v1.4.1...v1.5.0)

#### What's Changed

- Skip packaging option - resolves
[#&#8203;108](https://togithub.com/helm/chart-releaser-action/issues/108)
by [@&#8203;gmorse81](https://togithub.com/gmorse81) in
[helm/chart-releaser-action#109
- Remove deprecated charts-repo-url option by
[@&#8203;jftanner](https://togithub.com/jftanner) in
[helm/chart-releaser-action#123
- default action to cr v1.5.0 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#127

#### New Contributors

- [@&#8203;gmorse81](https://togithub.com/gmorse81) made their first
contribution in
[helm/chart-releaser-action#109
- [@&#8203;jftanner](https://togithub.com/jftanner) made their first
contribution in
[helm/chart-releaser-action#123

**Full Changelog**:
helm/chart-releaser-action@v1...v1.5.0

###
[`v1.4.1`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.4.1)

[Compare
Source](https://togithub.com/helm/chart-releaser-action/compare/v1.4.0...v1.4.1)

#### What's Changed

- document required permissions by
[@&#8203;davidkarlsen](https://togithub.com/davidkarlsen) in
[helm/chart-releaser-action#114
- bump cr to v1.4.1 by [@&#8203;cpanato](https://togithub.com/cpanato)
in
[helm/chart-releaser-action#121

**Full Changelog**:
helm/chart-releaser-action@v1.4.0...v1.4.1

###
[`v1.4.0`](https://togithub.com/helm/chart-releaser-action/releases/tag/v1.4.0)

[Compare
Source](https://togithub.com/helm/chart-releaser-action/compare/v1.3.0...v1.4.0)

#### What's Changed

- update chart release action to use CR release v1.4.0 by
[@&#8203;cpanato](https://togithub.com/cpanato) in
[helm/chart-releaser-action#106

**Full Changelog**:
helm/chart-releaser-action@v1.3.0...v1.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/newrelic/helm-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag --charts-repo is deprecated
4 participants