Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customdata to Jmeter tests (#179) #180

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

amandahla
Copy link
Contributor

@amandahla amandahla commented Jan 26, 2022

Implementation of #179

  • Requirement: The Dynamic volume provisioning must be set on the cluster

  • If JMETER_WORKER_REMOTE_CUSTOM_DATA_ENABLED is set, before pod creation, a PVC will be created asking the cluster for a volume of size defined in the environment variable JMETER_WORKER_REMOTE_CUSTOM_DATA_VOLUME_SIZE and access mode ReadWriteMany.

  • The volume will be the same for all pods and data from S3 bucket will be cloned using Rclone

Get variables from envvar file:

JMETER_WORKER_REMOTE_CUSTOM_DATA_ENABLED,true
JMETER_WORKER_REMOTE_CUSTOM_DATA_BUCKET,mybucket
JMETER_WORKER_REMOTE_CUSTOM_DATA_VOLUME_SIZE,1Gi
RCLONE_CONFIG_REMOTECUSTOMDATA_TYPE,s3
RCLONE_CONFIG_REMOTECUSTOMDATA_ACCESS_KEY_ID,value1
RCLONE_CONFIG_REMOTECUSTOMDATA_SECRET_ACCESS_KEY,value2
RCLONE_CONFIG_REMOTECUSTOMDATA_REGION,undefined
RCLONE_CONFIG_REMOTECUSTOMDATA_ENDPOINT,endpoint.com

@amandahla amandahla force-pushed the iss179 branch 3 times, most recently from f8a42b5 to aa5b859 Compare January 26, 2022 21:09
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #180 (c6986d4) into master (d269e22) will decrease coverage by 1.52%.
The diff coverage is 2.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   59.74%   58.22%   -1.53%     
==========================================
  Files          36       36              
  Lines        2760     2834      +74     
==========================================
+ Hits         1649     1650       +1     
- Misses        991     1062      +71     
- Partials      120      122       +2     
Impacted Files Coverage Δ
pkg/backends/jmeter/resources.go 68.75% <2.66%> (-16.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d269e22...c6986d4. Read the comment docs.

@amandahla amandahla changed the title WIP: Add customdata to Jmeter tests (#179) Add customdata to Jmeter tests (#179) Feb 14, 2022
@amandahla
Copy link
Contributor Author

@lucasmdrs friendly ping 😊

Copy link
Contributor

@lucasmdrs lucasmdrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amandahla thanks for the contribution! 💚

I'm leaving a couple of comments, please take a look when you have the time
Also, please make sure to document those environment variables 📝

pkg/backends/jmeter/resources.go Outdated Show resolved Hide resolved
pkg/core/waitfor/waitfor.go Outdated Show resolved Hide resolved
@amandahla
Copy link
Contributor Author

@lucasmdrs It seems like the same problem that happened in #206 , right?

@lucasmdrs
Copy link
Contributor

hey @amandahla , that's a different one. there are some trailing spaces in the doc:

------
/github/workspace/docs/jmeter/writing-tests.md:395:371 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

@lucasmdrs
Copy link
Contributor

Thank you for the awesome contribution @amandahla !
💚 💙 💜 💛 ❤️

@lucasmdrs lucasmdrs merged commit 1b72557 into hellofresh:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants