Add custom event type replacing crossterm's Event #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be nice for #3233. I'm doing some gyrations in crossterm-rs/crossterm#693 to keep Copy on its event type. That change could be simpler if Copy could be dropped in crossterm, and having a custom event type in Helix would make that easier. |
archseer
approved these changes
Aug 5, 2022
|
Can you resolve the merge conflict here? |
Ported over from 61365df in the `gui` branch. This will allow adding our own events, most notably an idle timer event (useful for adding debounced input in [dynamic pickers][1] used by interactive global search and workspace symbols). [1]: helix-editor#3110
archseer
force-pushed
the
native-event-type
branch
from
f73a887
to
98809b9
Compare
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Ported over from 61365df in the `gui` branch. This will allow adding our own events, most notably an idle timer event (useful for adding debounced input in [dynamic pickers][1] used by interactive global search and workspace symbols). [1]: helix-editor#3110 Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom event type replacing crossterm's Event
Ported over from 61365df in the
guibranch. This will allow adding our own events, most notably an idle timer event (useful for adding debounced input in dynamic pickers used by interactive global search and workspace symbols).