re-adding file watching #2629
Closed
re-adding file watching #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyrime Ohhh that good, I based on this code and I managed to solve the problem that commented in #2479, I added the ( DidChangeWatchedFiles Notification ) for this case, and it worked. But much better if you are already working on it, I will proceed to close this PR to not cause conflicts with yours. Here is a video of my implementation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-added the files so they can be merged (Taken from PR #588)
If it can be merged so that someone more knowledgeable in helix code can implement missing functions such as the file lookup required in (LSP - DidChangeWatchedFiles Notification).
One of the problems to be solved: #2479