Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional parameters to config file #375

Merged
merged 2 commits into from
May 30, 2024

Conversation

Mettbrot
Copy link

add the two filter options as parameters to the config file

@Mettbrot Mettbrot force-pushed the feature/additional_parameters branch 2 times, most recently from 83b81f1 to f1d276d Compare February 18, 2024 12:22
@Mettbrot
Copy link
Author

@helgeerbe do you rather want these PRs to target dev?

@helgeerbe
Copy link
Owner

Yes please. Dev is our staging branch.

@helgeerbe helgeerbe marked this pull request as draft February 19, 2024 10:09
@Mettbrot Mettbrot force-pushed the feature/additional_parameters branch from f1d276d to 314ca98 Compare February 19, 2024 21:05
@Mettbrot Mettbrot changed the base branch from main to dev February 19, 2024 21:06
@Mettbrot
Copy link
Author

@helgeerbe done.

@Mettbrot Mettbrot force-pushed the feature/additional_parameters branch from e1ad912 to 1f9e3ba Compare February 21, 2024 20:34
@Mettbrot Mettbrot force-pushed the feature/additional_parameters branch from 1f9e3ba to 07d6b97 Compare April 13, 2024 09:21
@Mettbrot Mettbrot marked this pull request as ready for review April 13, 2024 11:05
@Mettbrot
Copy link
Author

Mettbrot commented Apr 13, 2024

I also moved the building of filters for the where clause to the model, so everything sits together.

@helgeerbe
I was able to test this today, so I consider this ready for review/merge.

@helgeerbe helgeerbe merged commit 0e82a93 into helgeerbe:dev May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants